mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64351: Moved generated CSI code into public directories.
Date Wed, 06 Dec 2017 18:26:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64351/#review193012
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 5, 2017, 10:05 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64351/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 10:05 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves the Container Storage Interface (CSI) code generated from
> its protobufs into the `include` directory so that other public
> headers can use them.  The `csi/spec.hpp` was moved too, because
> we prefer to include a layer of header indirection when adding
> generated headers into non-generated headers.
> 
> An upcoming module specifically for CSI support will need to return
> objects defined in the CSI specification.  And because modules have
> public interfaces, we'll need the generated headers to be public too.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449 
>   src/csi/client.hpp 91dda0d44544c8901a9f71ef7f8338205b8ed598 
>   src/csi/spec.hpp c819be30312e32275b2d17ade35ba9f500f81b80 
>   src/tests/mock_csi_plugin.hpp 162dc6499a7ae880b30ec801ed399b7a3438bdc6 
> 
> 
> Diff: https://reviews.apache.org/r/64351/diff/1/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message