mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Re: Review Request 63914: Changed agent reregistration to work with message directly.
Date Wed, 06 Dec 2017 16:24:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63914/
-----------------------------------------------------------

(Updated Dec. 6, 2017, 4:24 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Changes
-------

Rebased (non-trivial due to changes in https://reviews.apache.org/r/64011/ ).


Bugs: MESOS-6972
    https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
-------

`reregisterSlave` now accepts `ReregisterSlaveMessage&&`, which opts-out
of using protobuf arena, and allows passing message through dispatch
chain without making any copies.
Conversion of repeated message fields to `std::vector`s is performed
only when needed.


Diffs (updated)
-----

  src/master/master.hpp d42acae5a7d31dccf7073b57c3f2ddcfadea9e55 
  src/master/master.cpp 16cdde73b90b2e1514c6196850b8df75a3b6ff28 
  src/master/validation.hpp ac54062ea09f97ad96bd17deb106ea89a57f394a 
  src/master/validation.cpp 8b5848bfd8c069f34a92a9a68597955c6e0c2ee2 
  src/tests/master_validation_tests.cpp 6398f16a3e1c0bbf0b188a5993b1d4ad9e105f41 


Diff: https://reviews.apache.org/r/63914/diff/5/

Changes: https://reviews.apache.org/r/63914/diff/4-5/


Testing
-------

make check


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message