mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 63953: Added logging based on container class.
Date Wed, 06 Dec 2017 14:47:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63953/
-----------------------------------------------------------

(Updated Dec. 6, 2017, 2:47 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Fixed issues.


Bugs: MESOS-7361
    https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description
-------

This change adjusts log level based on the container class.
If the class is `DEBUG` we print the log entry at a verbose
level 1, otherwise we print it at the `INFO` level.

We use the added macro in mesos containerizer so that COMMAND
checks cause less INFO logs (15 lines instead of 26 before).


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.hpp e2739e017cb8dda37d94ad809ca1bd461f308bfb

  src/slave/containerizer/mesos/containerizer.cpp 7f3b86d87cf82429c2627d4a32eb0d5adbcc3f29



Diff: https://reviews.apache.org/r/63953/diff/6/

Changes: https://reviews.apache.org/r/63953/diff/5-6/


Testing
-------

Started a Mesos cluster and used `mesos-execute` with this task group to check that the behaviour
after this patch is the one expected:

```
{
  "tasks": [
    {
      "name": "Name of the task",
      "task_id": {
        "value": "task-group"
      },
      "agent_id": {
        "value": ""
      },
      "resources": [
        {
          "name": "cpus",
          "type": "SCALAR",
          "scalar": {
            "value": 0.01
          }
        },
        {
          "name": "mem",
          "type": "SCALAR",
          "scalar": {
            "value": 2
          }
        }
      ],
      "command": {
        "value": "sleep 1000"
      },
      "check": {
        "type": "COMMAND",
        "command": {
          "command": {
            "value": "echo \"Bonjour\""
          },
          "uris": []
        }
      }
    }
  ]
}
```

And:
```
$ nice make check
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message