mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.
Date Wed, 06 Dec 2017 10:26:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64370/#review192973
-----------------------------------------------------------


Fix it, then Ship it!




Could you fix the mixup between `UPDATE_STATE` and `UpdateSlaveMessage` in the description?


src/resource_provider/message.hpp
Line 79 (original), 79 (patched)
<https://reviews.apache.org/r/64370/#comment271409>

    Why don't we just output the info?



src/slave/slave.cpp
Line 6865 (original), 6865 (patched)
<https://reviews.apache.org/r/64370/#comment271408>

    Let's add a `CHECK(message->updateState->info.has_id()` here.



src/slave/slave.cpp
Lines 6868-6875 (patched)
<https://reviews.apache.org/r/64370/#comment271410>

    This could be simplified to
    
        resourceProviderInfos[resourceProviderId] = message->updateState->info;



src/tests/resource_provider_manager_tests.cpp
Lines 344 (patched)
<https://reviews.apache.org/r/64370/#comment271411>

    Let's assert that the info has an id.


- Benjamin Bannier


On Dec. 6, 2017, 11:16 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64370/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 11:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To support sending 'ResourceProviderInfo's of all known resource
> providers to the master as part of a 'UPDATE_SLAVE' message, these
> information has been added to the 'UPDATE_STATE' message. Also, an agent
> now keeps track of all 'ResourceProviderInfo's.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
>   src/resource_provider/message.hpp c94e9c7f0bb512cc579b5fe569831002a32256b0 
>   src/slave/slave.hpp 06afd522ac424faa427366219cb212ee18a81c33 
>   src/slave/slave.cpp 49270013537356c8fe9150d757b064bc3bbae3cb 
>   src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01

> 
> 
> Diff: https://reviews.apache.org/r/64370/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message