mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63387: Added publish/unpublish in storage local resource provider.
Date Wed, 06 Dec 2017 02:05:07 GMT


> On Dec. 6, 2017, 12:23 a.m., Jie Yu wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 696-698 (patched)
> > <https://reviews.apache.org/r/63387/diff/6/?file=1908770#file1908770line696>
> >
> >     Can you comment on why this is not a fatal error and it is safe to ignore?

I'll follow the error handling we have for `ResourceProviderState` checkpointing.


> On Dec. 6, 2017, 12:23 a.m., Jie Yu wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 749-752 (patched)
> > <https://reviews.apache.org/r/63387/diff/6/?file=1908770#file1908770line749>
> >
> >     Why do you need this? Can you add a `default` and set it to UNREACHABLE?

https://github.com/google/protobuf/issues/3917


> On Dec. 6, 2017, 12:23 a.m., Jie Yu wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 962-965 (patched)
> > <https://reviews.apache.org/r/63387/diff/6/?file=1908770#file1908770line962>
> >
> >     Can this just be `default`?

Ditto.


> On Dec. 6, 2017, 12:23 a.m., Jie Yu wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 1578-1582 (patched)
> > <https://reviews.apache.org/r/63387/diff/6/?file=1908770#file1908770line1578>
> >
> >     Do you need this?

No I don't need. Missed this during refactoring :(


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63387/#review192946
-----------------------------------------------------------


On Dec. 5, 2017, 5:59 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63387/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 5:59 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8143
>     https://issues.apache.org/jira/browse/MESOS-8143
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Storage local resource provider can now handle PUBLISH events.
> Although we don't do UNPUBLISH for now, the unpublish function is
> still required for deleting volumes.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d5ca797c5a57a2763374d391a7e9358fe29f5e06 
>   src/csi/state.hpp PRE-CREATION 
>   src/csi/state.proto PRE-CREATION 
>   src/csi/utils.hpp 54cf34b40bd48282bbe3f8bcfe664540d9ce79b5 
>   src/csi/utils.cpp 590e5f4f763734748932584e383287bf94a5ec18 
>   src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7

> 
> 
> Diff: https://reviews.apache.org/r/63387/diff/6/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message