mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().
Date Tue, 05 Dec 2017 18:51:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/#review192903
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 5, 2017, 5:39 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64010/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 5:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is done mainly in preparation for the upcoming agent
> reconfiguration patches, where it will become possible that
> `updateSlave()` is passed a different SlaveInfo than `addSlave()`,
> and schedulers who rely on some fields in it for their scheduling
> decisions need to be able to check and compare them.
> 
> Additionally, the HierarchicalDRFAllocator was changed to store
> the full SlaveInfo for every slave instead of storing domain and
> hostname separately.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp acb9e4f6a843e64c915c43c218d8a533ca63333b 
>   src/master/allocator/mesos/allocator.hpp 48254b6e0974bdc16ffda04d3d271538048d3206 
>   src/master/allocator/mesos/hierarchical.hpp 41ffe17def133d7e735afa26a6fedd154e51f4b4

>   src/master/allocator/mesos/hierarchical.cpp 4428541e63561f7c3bc3bc61f4b47e35216f6442

>   src/master/master.cpp 31991b5f7f7f4e7dc73d71a3160348bfc0a627c3 
>   src/tests/allocator.hpp fc5d9efc8dab3bd971fa8938e3f82e8291c4ab9d 
>   src/tests/hierarchical_allocator_tests.cpp 154049c47f2dae2df8d1bb4ddb5c48c478bb3d0e

> 
> 
> Diff: https://reviews.apache.org/r/64010/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2299/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message