mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64146: Added offer operation update acknowledgement to the agent.
Date Tue, 05 Dec 2017 18:24:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64146/#review192893
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 3860 (patched)
<https://reviews.apache.org/r/64146/#comment271237>

    `operation != nullptr`


- Jie Yu


On Dec. 5, 2017, 7:07 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64146/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 7:07 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
>     https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent's offerOperationUpdateAcknowlegement handler is
> updated to pass acknowledgements to the resource provider
> manager.
> 
> The agent's resource provider message handler is also
> updated to avoid removing offer operations, since this
> should actually be done upon acknowledgement of the update.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
> 
> 
> Diff: https://reviews.apache.org/r/64146/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message