mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Re: Review Request 63761: Replaced std::shared_ptr with std::unique_ptr in dispatch.
Date Tue, 05 Dec 2017 18:08:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63761/
-----------------------------------------------------------

(Updated Dec. 5, 2017, 6:07 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
    https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
-------

Since `dispatch` can now handle movable only parameters, `Promise` and
functor can be safely wrapped into `std::unique_ptr` for efficiency.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/dispatch.hpp 155f362a888caef5ce2db803a109400ca4c7ec37

  3rdparty/libprocess/include/process/event.hpp 571ffb1ea5c4787f10c2f4dee249aadc8b904bc6 
  3rdparty/libprocess/src/process.cpp 64bcce215d19558dd493e30e96ca16577fe0722a 


Diff: https://reviews.apache.org/r/63761/diff/3/

Changes: https://reviews.apache.org/r/63761/diff/2-3/


Testing
-------

make check


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message