mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64151: Added a V1 API call to list resource providers.
Date Tue, 05 Dec 2017 17:06:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192877
-----------------------------------------------------------




include/mesos/agent/agent.proto
Lines 60 (patched)
<https://reviews.apache.org/r/64151/#comment271202>

    Let's add some minimal documentation here.



include/mesos/v1/agent/agent.proto
Lines 60 (patched)
<https://reviews.apache.org/r/64151/#comment271203>

    Let's add some minimal documentation here.



src/resource_provider/manager.hpp
Lines 28 (patched)
<https://reviews.apache.org/r/64151/#comment271205>

    Unused?



src/resource_provider/manager.hpp
Lines 63 (patched)
<https://reviews.apache.org/r/64151/#comment271206>

    Could we explicitly include `mesos.hpp` for `ResourceProviderInfo`?



src/resource_provider/manager.cpp
Lines 466 (patched)
<https://reviews.apache.org/r/64151/#comment271207>

    `foreachvalue`? We should also include `stout/foreach.hpp` here.



src/slave/http.cpp
Lines 1862 (patched)
<https://reviews.apache.org/r/64151/#comment271208>

    Let's create a ticket tracking authorization of this call and mention it in a `TODO` here.



src/slave/http.cpp
Lines 1879-1881 (patched)
<https://reviews.apache.org/r/64151/#comment271213>

    This could become slightly less nasty if we would declare outside the loop a
    
        agent::Response::GetResourceProviders* getResourceProviders =
          response.mutable_get_resource_providers();
          
    It does not help a lot though.



src/tests/api_tests.cpp
Lines 6046 (patched)
<https://reviews.apache.org/r/64151/#comment271218>

    This would be much simpler with a `MockResourceProvider`.



src/tests/api_tests.cpp
Lines 6094-6095 (patched)
<https://reviews.apache.org/r/64151/#comment271220>

    EXPECT_EQ(
          1, v1Response->get_resource_providers().resource_providers_size());



src/tests/api_tests.cpp
Lines 6097 (patched)
<https://reviews.apache.org/r/64151/#comment271221>

    We could bind to a const ref here.



src/tests/api_tests.cpp
Lines 6102 (patched)
<https://reviews.apache.org/r/64151/#comment271222>

    This needs to be tweak if we use a `MockResourceProvider`.



src/tests/resource_provider_manager_tests.cpp
Lines 839 (patched)
<https://reviews.apache.org/r/64151/#comment271223>

    Could we use a `MockResourceProvider` here as well?



src/tests/resource_provider_manager_tests.cpp
Lines 880 (patched)
<https://reviews.apache.org/r/64151/#comment271225>

    This needs to be an assert.



src/tests/resource_provider_manager_tests.cpp
Lines 881 (patched)
<https://reviews.apache.org/r/64151/#comment271224>

    This needs to be tweaked if we use a `MockResourceProvider`.


- Benjamin Bannier


On Dec. 5, 2017, 3:34 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8270
>     https://issues.apache.org/jira/browse/MESOS-8270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b 
>   include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b 
>   src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b 
>   src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
>   src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3 
>   src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa 
>   src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2 
>   src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa 
>   src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01

> 
> 
> Diff: https://reviews.apache.org/r/64151/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message