mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 64337: Fixed CallableOnce operator() signature.
Date Tue, 05 Dec 2017 15:30:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64337/#review192872
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Dec. 5, 2017, 4:13 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64337/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 4:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes `operator()` signature to match the one defined in
> `CallableOnce` template parameter.
> Previously used form incorrectly specifies that `operator()` can be
> invoked with arbitrary number and types of parameters, which can break
> other templates using SFINAE to check if functor can be invoked with
> specific parameters.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp 96586bd572093d2874a617252ed22b9e6874236b 
> 
> 
> Diff: https://reviews.apache.org/r/64337/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message