mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.
Date Tue, 05 Dec 2017 07:41:07 GMT


> On Nov. 30, 2017, 7:49 p.m., Jie Yu wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 39 (patched)
> > <https://reviews.apache.org/r/63804/diff/6/?file=1904718#file1904718line39>
> >
> >     For the sake of consistency. I think we should either rename this to `RECONCILE`,
or rename above types to `ACKNOWLEDGE_OFFER_OPERATION` and `APPLY_OFFER_OPERATION` and `PUBLISH_RESOURCES`

I renamed to ACKNOWLEDGE_OFFER_OPERATION in a previous review, but I have not updated PUBLISH_RESOURCES
yet. I'll resolve this issue once I submit a patch for that, and will leave a link here.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63804/#review192349
-----------------------------------------------------------


On Dec. 5, 2017, 7:39 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63804/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 7:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8199
>     https://issues.apache.org/jira/browse/MESOS-8199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added plumbing for master to reconcile offer operations with agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b

>   include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb

>   src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d 
>   src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b 
>   src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
>   src/resource_provider/storage/provider.cpp d35b0d02992e3730ca47906b34c21e1ba9c653e7

>   src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
>   src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
>   src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
> 
> 
> Diff: https://reviews.apache.org/r/63804/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message