mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 64098: Send status updates when agent re-registers.
Date Tue, 05 Dec 2017 06:02:22 GMT


> On Dec. 4, 2017, 6:43 p.m., Jiang Yan Xu wrote:
> > src/tests/master_allocator_tests.cpp
> > Lines 1452-1454 (original), 1452-1459 (patched)
> > <https://reviews.apache.org/r/64098/diff/8/?file=1906533#file1906533line1452>
> >
> >     So these tests had to be changed becauase the master is not using the `replicated_log`
registry flag so it cannot remember the agent...
> >     
> >     I think the right change is to use `replicated_log` for the tests that don't
make sense to change for this patch.
> >     
> >     Note that the use of replicated log registrar breaks on Windows (see MESOS-5932)
so we need to make sure such tests are disabled on Windows.
> >     
> >     The way to do it is to check whether the file is in this list: https://github.com/apache/mesos/blob/42952093c081e494d36721bc6c56ab73069a82e4/src/tests/CMakeLists.txt#L152
> >     
> >     If it is, then it is already not built on Windows.
> >     
> >     If not, we can use `TEST_F_TEMP_DISABLED_ON_WINDOWS` as part of the test name
to disable it.
> >     
> >     Please review all the tests in this RR for this.
> 
> Megha Sharma wrote:
>     Thank you Yan, Good find. Working on fixing the tests.

Updated the RR, verified that all tests but one (`partition_tests.cpp`) are present in the
section `if (NOT WIN32)` of the mentioned file. I have added `TEST_F_TEMP_DISABLED_ON_WINDOWS`
to individual tests in `partition_tests.cpp` which have been updated to use replicated_logs
in this RR.


- Megha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64098/#review192733
-----------------------------------------------------------


On Dec. 2, 2017, 12:29 a.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64098/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6406
>     https://issues.apache.org/jira/browse/MESOS-6406
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master will send task status updates to frameworks when an agent
> which has been previously removed by the master for being unreachable
> or is unknown to the master due to the garbage collection of
> the unreachable and gone agents in the registry re-registers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e 
>   src/tests/master_allocator_tests.cpp 3400d70bb0ba564eac43c4639eee0efd4d8059e6 
>   src/tests/master_tests.cpp 57eae320a7a398527cd3623c89bf67f319a8e955 
>   src/tests/partition_tests.cpp 31ebfe1655438eceae74d72a223df03a9dbd282d 
>   src/tests/persistent_volume_tests.cpp 4aa3c2e8b0f461cd78053707cff8bcb2e6f2b0d7 
>   src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 
>   src/tests/upgrade_tests.cpp 7f434dbba858f636719eec24e92b306b76430c4c 
> 
> 
> Diff: https://reviews.apache.org/r/64098/diff/11/
> 
> 
> Testing
> -------
> 
> with make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message