mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63023: Added a test CSI plugin.
Date Tue, 05 Dec 2017 02:12:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63023/#review192744
-----------------------------------------------------------


Fix it, then Ship it!





src/csi/utils.hpp
Lines 40 (patched)
<https://reviews.apache.org/r/63023/#comment271001>

    2 lines apart



src/csi/utils.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/63023/#comment271002>

    mount flag order is not important.


- Jie Yu


On Nov. 28, 2017, 6 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63023/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 6 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8102
>     https://issues.apache.org/jira/browse/MESOS-8102
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test CSI plugin would just create subdirectories under its working
> directories to mimic the behavior of creating volumes, then bind-mount
> those volumes to mimic publish.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 
>   src/csi/utils.hpp PRE-CREATION 
>   src/csi/utils.cpp PRE-CREATION 
>   src/examples/test_csi_plugin.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63023/diff/5/
> 
> 
> Testing
> -------
> 
> make tests
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message