mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64248: Added `cpp17::invoke` in <stout/cpp17.hpp>.
Date Tue, 05 Dec 2017 01:07:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64248/#review192798
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/cpp17.hpp
Lines 36-37 (patched)
<https://reviews.apache.org/r/64248/#comment271088>

    What happens if you pass reference wrapper, it just doesn't compile? Maybe clarify that?



3rdparty/stout/tests/cpp17_tests.cpp
Lines 21 (patched)
<https://reviews.apache.org/r/64248/#comment271089>

    Can you sweep these comments to start with a capital letter and end with a period?


- Benjamin Mahler


On Dec. 1, 2017, 3:36 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64248/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 3:36 p.m.)
> 
> 
> Review request for mesos and Dmitry Zhuk.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `cpp17::invoke` in <stout/cpp17.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 
>   3rdparty/stout/include/stout/cpp17.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 6e5773f1e03671de7ac007caf49edd0f1cd7aedd 
>   3rdparty/stout/tests/cpp17_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64248/diff/2/
> 
> 
> Testing
> -------
> 
> Added `cpp17_tests.cpp`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message