mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.
Date Tue, 05 Dec 2017 00:45:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63498/
-----------------------------------------------------------

(Updated Dec. 5, 2017, 12:45 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Addressed Jie's comment.


Bugs: MESOS-7550
    https://issues.apache.org/jira/browse/MESOS-7550


Repository: mesos


Description (updated)
-------

If the `root` field is set to a relative path, it would mean that the
path is relative to the agent work directory. This provides the ability
for a containerizer to construct the mount points of CSI volumes without
knowing the resource providers.


Diffs (updated)
-----

  CHANGELOG 0d68559d9fd1264c381b6cc6cfe28861b3b26488 
  docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23 
  include/mesos/mesos.proto 11089b7d6f48f001ae64e8b0c67a2732684aa2fa 
  include/mesos/v1/mesos.proto c496da927903f472c78d455b7fdf886d8fb692c4 
  src/slave/paths.hpp c73130fd743d10a8635618f3314b13a3d7943ea8 
  src/slave/paths.cpp fce18c5649d993f9f761a0f955706a5d582d5dc8 


Diff: https://reviews.apache.org/r/63498/diff/2/

Changes: https://reviews.apache.org/r/63498/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message