mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64101: Skip registry update when nothing changed.
Date Mon, 04 Dec 2017 23:45:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64101/#review192792
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 6586 (patched)
<https://reviews.apache.org/r/64101/#comment271066>

    s/nothing/`slaveInfo`/



src/master/master.cpp
Lines 6622 (patched)
<https://reviews.apache.org/r/64101/#comment271067>

    s/nothing/`slaveInfo`/


- Vinod Kone


On Dec. 4, 2017, 4:26 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64101/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 4:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Most of the time, agents will not change their configuration
> when they restart, so we can skip updating the registry in this
> case.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
> 
> 
> Diff: https://reviews.apache.org/r/64101/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2302/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message