mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.
Date Mon, 04 Dec 2017 22:08:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 10:08 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8054
    https://issues.apache.org/jira/browse/MESOS-8054


Repository: mesos


Description
-------

This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.


Diffs (updated)
-----

  src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 


Diff: https://reviews.apache.org/r/64142/diff/2/

Changes: https://reviews.apache.org/r/64142/diff/1-2/


Testing
-------

make check


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message