mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.
Date Mon, 04 Dec 2017 22:05:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192773
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp
Lines 612 (patched)
<https://reviews.apache.org/r/64011/#comment271026>

    `updated = true`



src/master/allocator/mesos/hierarchical.cpp
Line 607 (original), 621 (patched)
<https://reviews.apache.org/r/64011/#comment271027>

    see above. this needs to be pulled up to #602?



src/tests/hierarchical_allocator_tests.cpp
Lines 6277 (patched)
<https://reviews.apache.org/r/64011/#comment271028>

    `updateSlave()`



src/tests/hierarchical_allocator_tests.cpp
Lines 6338 (patched)
<https://reviews.apache.org/r/64011/#comment271035>

    I wonder what caused the allocation to happen given you didn't set `updated` to true in
`updateSlave` for attribute changes?


- Vinod Kone


On Dec. 4, 2017, 4:30 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 4:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
> 
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76

>   src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1

>   src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46 
>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
>   src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee

> 
> 
> Diff: https://reviews.apache.org/r/64011/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message