mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64146: Added offer operation update acknowledgement to the agent.
Date Mon, 04 Dec 2017 21:57:45 GMT


> On Nov. 30, 2017, 11:33 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 3851 (patched)
> > <https://reviews.apache.org/r/64146/diff/1/?file=1903841#file1903841line3852>
> >
> >     Currently, for agent default resources, we call `removeOfferOperation` right
after the operation is processed (given that we don't have status update manager or checkpointing
for operations), and send best effort status update to the master.
> >     
> >     I am wondering if we need ack at all for agent default resources operations.
That mean, we should probably remove the offer operation for agent default resources in `offerOperationStatusUpdate`.
> >     
> >     If there is a fail over, and the update is lost, the agent will reconcile with
the master during re-registration and master will notice that and call removeOfferOperation
there (in updateSlave handler).

The current master code will only acknowledge updates which have the `status_uuid` field set
(updates which are being retried), and since the agent doesn't set that field for its best-effort
updates, I don't think we need to worry about agent default resources in this handler right
now.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64146/#review192391
-----------------------------------------------------------


On Nov. 29, 2017, 5:56 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64146/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
>     https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent's offerOperationUpdateAcknowlegement handler is
> updated to pass acknowledgements to the resource provider
> manager.
> 
> The agent's resource provider message handler is also
> updated to avoid removing offer operations, since this
> should actually be done upon acknowledgement of the update.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb 
> 
> 
> Diff: https://reviews.apache.org/r/64146/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message