mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63914: Changed agent reregistration to work with message directly.
Date Mon, 04 Dec 2017 21:18:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63914/#review192747
-----------------------------------------------------------


Ship it!




Exciting to see this stuff come together! Looks good, thanks Dmitry!

I left some minor comments, but feel free to leave the patch as is, myself and/or mpark could
make some adjustments prior to committing if that's easier for you.


src/master/master.cpp
Lines 6492-6499 (patched)
<https://reviews.apache.org/r/63914/#comment271004>

    Hm.. I'm curious if you have any thoughts on avoiding copying it out of the message. We
can look at that more closely in a different patch though :)



src/master/master.cpp
Line 6589 (original), 6560 (patched)
<https://reviews.apache.org/r/63914/#comment271007>

    Per mpark's suggestion, not your fault, but something like `checkpointResourcesMessage`
here would be more readable.



src/master/master.cpp
Lines 6672-6682 (patched)
<https://reviews.apache.org/r/63914/#comment271009>

    Ditto here, curious if you had any thoughts on eliminating these copies, but we can look
at that later :)



src/tests/master_validation_tests.cpp
Line 4213 (original), 4213 (patched)
<https://reviews.apache.org/r/63914/#comment271019>

    Not yours, but this should probably be ReregisterSlaveValidationTest.


- Benjamin Mahler


On Nov. 21, 2017, 5:53 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63914/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 5:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `reregisterSlave` now accepts `ReregisterSlaveMessage&&`, which opts-out
> of using protobuf arena, and allows passing message through dispatch
> chain without making any copies.
> Conversion of repeated message fields to `std::vector`s is performed
> only when needed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0f8a2ac72c3484f911853c2994fc71a488d66d96 
>   src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095 
>   src/master/validation.hpp ac54062ea09f97ad96bd17deb106ea89a57f394a 
>   src/master/validation.cpp 8b5848bfd8c069f34a92a9a68597955c6e0c2ee2 
>   src/tests/master_validation_tests.cpp 0e1c8b490ebe10bc50b8b6b530fa85128b967584 
> 
> 
> Diff: https://reviews.apache.org/r/63914/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message