mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64093: Added operators for offer operation update protobuf classes.
Date Mon, 04 Dec 2017 20:19:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192755
-----------------------------------------------------------


Fix it, then Ship it!





src/messages/messages.cpp
Line 63 (original), 112 (patched)
<https://reviews.apache.org/r/64093/#comment271015>

    Make capitalization ("Status" vs. "status") consistent across this overload and the one
below.


- Greg Mann


On Dec. 2, 2017, 2:11 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2017, 2:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8197
>     https://issues.apache.org/jira/browse/MESOS-8197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added operators for offer operation update protobuf classes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp d28d5384af95d1992ca32d3afcdd16d1de678005 
>   src/common/type_utils.cpp a27222139fa3c841fd8ade17b4d0210e7b7dfa4f 
>   src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b 
>   src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d 
> 
> 
> Diff: https://reviews.apache.org/r/64093/diff/4/
> 
> 
> Testing
> -------
> 
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message