> On Dec. 2, 2017, 1:02 a.m., Qian Zhang wrote:
> > src/slave/slave.cpp
> > Lines 621 (patched)
> > <https://reviews.apache.org/r/64267/diff/1/?file=1906550#file1906550line621>
> >
> > What if `image_providers` is specified by the operator but Mesos containerizer
is not enabled? Do we still want to enable auto image gc in this case?
we should have the containerizer check. thanks!
> On Dec. 2, 2017, 1:02 a.m., Qian Zhang wrote:
> > src/slave/slave.cpp
> > Lines 6171-6173 (patched)
> > <https://reviews.apache.org/r/64267/diff/1/?file=1906550#file1906550line6171>
> >
> > This should be an `else if`, elsewise we will access `usage.get()` even it is
not ready.
good catch!
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64267/#review192621
-----------------------------------------------------------
On Dec. 1, 2017, 5:10 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64267/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 5:10 p.m.)
>
>
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
>
>
> Bugs: MESOS-8294
> https://issues.apache.org/jira/browse/MESOS-8294
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported basic auto image gc in the agent.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
> src/slave/slave.cpp a9aa987ade67542b85aeb51356d00a4c14c6be9d
>
>
> Diff: https://reviews.apache.org/r/64267/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|