mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.
Date Mon, 04 Dec 2017 18:54:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 6:54 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.


Changes
-------

Rebased on master and addressed comments.


Bugs: MESOS-6709
    https://issues.apache.org/jira/browse/MESOS-6709


Repository: mesos


Description
-------

Added dependency of curl to agent. Enabled most health check tests.


Diffs (updated)
-----

  src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
  src/tests/health_check_tests.cpp 56721fac4a464f3cad40dbf4e6bc4fb7b1a780d4 


Diff: https://reviews.apache.org/r/64104/diff/2/

Changes: https://reviews.apache.org/r/64104/diff/1-2/


Testing
-------

There are two health check tests which are not enabled yet, because they require the IOSwitchboard
to be ported first. We can't resolve MESOS-6709 quite yet until that is addressed. The rest
of the tests pass on both Linux/Windows, as mentioned in #64102


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message