mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Re: Review Request 64274: Added `lambda::partial` to <stout/lambda.hpp>.
Date Mon, 04 Dec 2017 18:18:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64274/#review192718
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


3rdparty/stout/include/stout/lambda.hpp
Lines 162 (patched)
<https://reviews.apache.org/r/64274/#comment270972>

    2 blank linkes befor and after?



3rdparty/stout/include/stout/lambda.hpp
Lines 172 (patched)
<https://reviews.apache.org/r/64274/#comment270967>

    { should be on the next line



3rdparty/stout/include/stout/lambda.hpp
Lines 181 (patched)
<https://reviews.apache.org/r/64274/#comment270968>

    ditto



3rdparty/stout/include/stout/lambda.hpp
Line 159 (original), 289 (patched)
<https://reviews.apache.org/r/64274/#comment270970>

    2 blank lines?


- Dmitry Zhuk


On Dec. 4, 2017, 3:21 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64274/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 3:21 p.m.)
> 
> 
> Review request for mesos and Dmitry Zhuk.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `lambda::partial` to <stout/lambda.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017 
>   3rdparty/stout/tests/lambda_tests.cpp ad8c2efddb6b64184670d0cfb33188ef843351ab 
> 
> 
> Diff: https://reviews.apache.org/r/64274/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message