mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.
Date Mon, 04 Dec 2017 17:44:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64033/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 5:44 p.m.)


Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone.


Bugs: MESOS-8247
    https://issues.apache.org/jira/browse/MESOS-8247


Repository: mesos


Description (updated)
-------

`ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered
to a driver-based executor. Since these messages are not retried,
without this patch an executor never starts a task and remains idle,
ignoring kill task request. This patch ensures all built-in driver-
based executors eventually shut down if kill task arrives before
the task has been started.


Diffs (updated)
-----

  src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f 
  src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc 
  src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 


Diff: https://reviews.apache.org/r/64033/diff/4/

Changes: https://reviews.apache.org/r/64033/diff/3-4/


Testing
-------

make check on MacOS 10.11.6

Manual testing using modified "exec.cpp" that drops executor registration confirmation.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message