mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction.
Date Fri, 01 Dec 2017 23:37:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 1, 2017, 3:37 p.m.)

Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Added check in update that `pid.isSome()`.

Repository: mesos


Replaced the two maps of `ContainerId -> pid` and `ContainerId -> limit`
with a mapping of `ContainerId -> struct Info { pid, limit }`. This
abstraction correctly ties the the `pid` and cpu/mem `limit` together.
Notably this fixes a subtle bug in `prepare` so that it can no longer be
called multiple times if a resource limit hadn't been set.

Furthermore, this patch imports all the types used in the source files
to enchance code conciseness, and then reformatted with `clang-format`.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/windows/cpu.hpp 8672b5943ff305b929dd7514581df4515dff1f50

  src/slave/containerizer/mesos/isolators/windows/cpu.cpp e9f4daccdd507312998984cad231c3c7d310af2b

  src/slave/containerizer/mesos/isolators/windows/mem.hpp 24426f7219bc7831c1682153d7c9c1a6e502e3d6

  src/slave/containerizer/mesos/isolators/windows/mem.cpp 5abcb4edfa350e1de5b34bfd43d4e961b7208799




`make check` on CentOS 7 (probably pointless)

`ctest` on Windows 10. All tests passed. (Building again after rebase.)


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message