mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64044: Recover controller and node services and clean up unused containers.
Date Fri, 01 Dec 2017 22:16:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64044/#review192537
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 465 (patched)
<https://reviews.apache.org/r/64044/#comment270747>

    Let's use csiPluginContainerInfo


- Jie Yu


On Dec. 1, 2017, 1:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64044/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 1:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The storage local resource provider now scans through the list of plugin
> containers from
> 
>   `<work_dir>/csi/<csi_type>/<csi_name>/containers/<container_id>`,
> 
> and kill containers that will no longer in use, then starts up the
> containers for the controller and node services.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78

> 
> 
> Diff: https://reviews.apache.org/r/64044/diff/2/
> 
> 
> Testing
> -------
> 
> The `prepareControllerService` and `prepareNodeService` functions are
> moved from r63022.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message