mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64258: Included `stout/os/permissions.hpp` for the secret generator.
Date Fri, 01 Dec 2017 21:58:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64258/#review192572
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 1, 2017, 8:13 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64258/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 8:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `os::Permissions` started being used in these files in `e1207f9d`,
> but not included. On Windows, no other header included it either, and so
> the SSL configuration of the build broke.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp abe48fdf56ba356d757d8c6e97d01ae3b6cfa0a3 
>   src/tests/cluster.cpp b530133fa77572f00ef8a945d3466a27eb95ceab 
> 
> 
> Diff: https://reviews.apache.org/r/64258/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on CentOS 7
> 
> Built and ran tests on Windows with `-DENABLE_SSL=ON`. Verified `libprocess-tests` SSLTest
suite passed.
> 
> Note that without this chain, the CI builds are currently broken.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message