mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 64258: Included `stout/os/permissions.hpp` for the secret generator.
Date Fri, 01 Dec 2017 20:13:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64258/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

The `os::Permissions` started being used in these files in `e1207f9d`,
but not included. On Windows, no other header included it either, and so
the SSL configuration of the build broke.


Diffs
-----

  src/slave/main.cpp abe48fdf56ba356d757d8c6e97d01ae3b6cfa0a3 
  src/tests/cluster.cpp b530133fa77572f00ef8a945d3466a27eb95ceab 


Diff: https://reviews.apache.org/r/64258/diff/1/


Testing
-------

`make check` on CentOS 7

Built and ran tests on Windows with `-DENABLE_SSL=ON`. Verified `libprocess-tests` SSLTest
suite passed.

Note that without this chain, the CI builds are currently broken.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message