mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 64255: Removed `os/realpath.hpp` from `posix/os.hpp`.
Date Fri, 01 Dec 2017 20:10:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64255/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

This is part of a clean-up chain to fix the problem where `stout/os.hpp`
previously made `os::realpath()` available, but it was instead moved to
its own header. Instead, files must include what is used, and so include
the `realpath.hpp` header.

Since `posix/os.hpp` doesn't use `os::realpath()`, its inclusion of
`os/realpath.hpp` was removed, and instead code using the function was
fixed to include the header directly.

Note that this now matches `windows/os.hpp`, which also does not include
`realpath.hpp`. The same pattern should be followed for other APIs as
needed.


Diffs
-----

  3rdparty/stout/include/stout/posix/os.hpp 8511dfd419a646df17eb687d732bb975f4c23d53 
  3rdparty/stout/tests/os/filesystem_tests.cpp 3946885b12a78c765e506c855a12aed1efbeafad 
  3rdparty/stout/tests/os_tests.cpp 26514f3604fcc81effbfcb6845116a62021272ca 


Diff: https://reviews.apache.org/r/64255/diff/1/


Testing
-------

See end of chain.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message