mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.
Date Fri, 01 Dec 2017 19:47:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64012/#review192539
-----------------------------------------------------------




src/tests/master_tests.cpp
Line 2758 (original), 2785 (patched)
<https://reviews.apache.org/r/64012/#comment270750>

    re-registration



src/tests/slave_tests.cpp
Lines 8828 (patched)
<https://reviews.apache.org/r/64012/#comment270752>

    you should expand the comment on what you are testing here.



src/tests/slave_tests.cpp
Line 8817 (original), 8831 (patched)
<https://reviews.apache.org/r/64012/#comment270753>

    Can you start a scheduler in this test and make sure it gets offers with new domains and
resources after the restart?



src/tests/slave_recovery_tests.cpp
Lines 4774 (patched)
<https://reviews.apache.org/r/64012/#comment270751>

    Can you add a test that checks that any attribute changes will result in filtered offers
being resent?


- Vinod Kone


On Dec. 1, 2017, 6:32 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64012/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 6:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag allows operators to weaken the checks performed by the agent
> when recovering state, in particular it allows to recover running tasks
> even when parts of the recovered SlaveInfo don't match the current
> state.
> 
> The set of possible changes is quite restricted for now,
> to avoid accidenetally introducing semantic bugs.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 15cda101099ce819b72d09bece37ce106b900bb0 
>   src/Makefile.am 3444388e1799a6de774c41c65d273084706ed6ca 
>   src/slave/compatibility.hpp PRE-CREATION 
>   src/slave/compatibility.cpp PRE-CREATION 
>   src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094 
>   src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf 
>   src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
>   src/slave/slave.cpp 3896e432fe4b40a458e75537ccfcdd689cdf3f43 
>   src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66 
>   src/tests/master_tests.cpp 57eae320a7a398527cd3623c89bf67f319a8e955 
>   src/tests/slave_compatibility_tests.cpp PRE-CREATION 
>   src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 
>   src/tests/slave_tests.cpp 8ab63ac70083f1acaf1d253f9818efd11add6e94 
> 
> 
> Diff: https://reviews.apache.org/r/64012/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message