-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192535
-----------------------------------------------------------
src/master/master.cpp
Lines 6923-6927 (original), 6894-6898 (patched)
<https://reviews.apache.org/r/64011/#comment270742>
this comment might be stale after your changes in the previous review.
change updateSlave return value to `Try<Nothing>`
src/master/master.cpp
Lines 11439 (patched)
<https://reviews.apache.org/r/64011/#comment270743>
s/reregistering/re-registering/
- Vinod Kone
On Dec. 1, 2017, 6:31 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 6:31 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
> src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e
>
>
> Diff: https://reviews.apache.org/r/64011/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
|