mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64252: Convert resource format of messages entering master.
Date Fri, 01 Dec 2017 18:57:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64252/#review192529
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 6048 (patched)
<https://reviews.apache.org/r/64252/#comment270731>

    s/format/format./
    
    TODO for moving this stuff (and for task and executor resources) including validation
into the installer handler.



src/master/master.cpp
Lines 6375 (patched)
<https://reviews.apache.org/r/64252/#comment270732>

    ditto. see above.


- Vinod Kone


On Dec. 1, 2017, 6:30 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64252/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 6:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Convert resource format of messages entering master.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e 
>   src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41 
> 
> 
> Diff: https://reviews.apache.org/r/64252/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message