mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().
Date Fri, 01 Dec 2017 18:31:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/
-----------------------------------------------------------

(Updated Dec. 1, 2017, 6:31 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

The current `SlaveInfo` of a slave is now passed as an additional
parameter to `updateSlave()`, to account for the possibility of
it changing during an agent restart.

While the existing HierarchicalDRFAllocator only cares about the domain
and hostname fields, the full SlaveInfo is passed since custom
allocators might base their scheduling decisions on other fields, for
example attributes.

Additionally, this also provides callers with an option to reset
existing offer filters for a given slave id when the update is
applied.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp acb9e4f6a843e64c915c43c218d8a533ca63333b 
  src/master/allocator/mesos/allocator.hpp 48254b6e0974bdc16ffda04d3d271538048d3206 
  src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76 
  src/master/allocator/mesos/hierarchical.cpp ab2abf868f9252154d934243521622c5cb107182 
  src/tests/allocator.hpp fc5d9efc8dab3bd971fa8938e3f82e8291c4ab9d 
  src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee 


Diff: https://reviews.apache.org/r/64010/diff/5/

Changes: https://reviews.apache.org/r/64010/diff/4-5/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message