mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.
Date Fri, 01 Dec 2017 18:16:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64096/#review192525
-----------------------------------------------------------




src/status_update_manager/offer_operation_status_update_manager.cpp
Lines 57-59 (patched)
<https://reviews.apache.org/r/64096/#comment270723>

    Yesterday we discussed moving the header's `typedef` out to file scope, which would let
you use it here.


- Greg Mann


On Dec. 1, 2017, 12:27 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64096/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 12:27 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8197
>     https://issues.apache.org/jira/browse/MESOS-8197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This class will handle the offer operation status updates generated by
> the agent and by resource providers.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 76ef6cac925e36a31e4f6c347271955411284056 
>   src/Makefile.am 4a3b728dc2cbfaf4b10068562778a87a6b331238 
>   src/status_update_manager/offer_operation_status_update_manager.hpp PRE-CREATION 
>   src/status_update_manager/offer_operation_status_update_manager.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 65fca826e8b46ad064096e0f02b771985bef95d0 
>   src/tests/offer_operation_status_update_manager_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64096/diff/3/
> 
> 
> Testing
> -------
> 
> This patch addes new tests that passed 5000 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message