mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Date Fri, 01 Dec 2017 17:52:50 GMT


> On Dec. 1, 2017, 3:25 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos libprocess-tests failed to build
> > 
> > Reviews applied: `['63859', '63860', '63861', '63862']`
> > 
> > Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
> > 
> > Relevant logs:
> > 
> > - [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-build-cmake-stdout.log):
> > 
> > ```
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996:
'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning
C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling
source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996:
'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning
C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996:
'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning
C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling
source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling
source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996:
'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning
C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning
C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling
source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996:
'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning
C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> > 
> > 
> > "C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> > (ClCompile target) -> 
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error
C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
> > 
> >     96 Warning(s)
> >     6 Error(s)
> > 
> > Time Elapsed 00:04:19.45
> > ```
> > 
> > - [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-CMakeOutput.log):
> > 
> > ```
> >   Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

> >   Creating directory "cmTC_0a201.dir\Debug\cmTC_0a201.tlog\".

> > InitializeBuildStatus:

> >   Creating "cmTC_0a201.dir\Debug\cmTC_0a201.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

> > ClCompile:

> >   C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_0a201.dir\Debug\" /Fd"cmTC_0a201.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

> >   Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

> >   Copyright (C) Microsoft Corporation.  All rights reserved.

> >   

> >   cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_0a201.dir\Debug\" /Fd"cmTC_0a201.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

> >   src.cxx

> >   

> > Link:

> >   C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_0a201.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0a201.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0a201.lib"
/MACHINE:X64  /machine:x64 cmTC_0a201.dir\Debug\src.obj

> >   cmTC_0a201.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_0a201.exe

> >   cmTC_0a201.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_0a201.pdb
(Full PDB)

> > FinalizeBuildStatus:

> >   Deleting file "cmTC_0a201.dir\Debug\cmTC_0a201.tlog\unsuccessfulbuild".

> >   Touching "cmTC_0a201.dir\Debug\cmTC_0a201.tlog\cmTC_0a201.lastbuildstate".

> > Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_0a201.vcxproj" (default
targets).

> > 

> > Build succeeded.

> >     0 Warning(s)

> >     0 Error(s)

> > 

> > Time Elapsed 00:00:01.74

> > 
> > Source file was:
> > int main() { return 0; }
> > ```
> > 
> > - [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/libprocess-tests-CMakeError.log):
> > 
> > ```
> > PrepareForBuild:

> >   Creating directory "cmTC_d1a3b.dir\Debug\".

> >   Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

> >   Creating directory "cmTC_d1a3b.dir\Debug\cmTC_d1a3b.tlog\".

> > InitializeBuildStatus:

> >   Creating "cmTC_d1a3b.dir\Debug\cmTC_d1a3b.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

> > ClCompile:

> >   C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_d1a3b.dir\Debug\" /Fd"cmTC_d1a3b.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

> >   Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

> >   Copyright (C) Microsoft Corporation.  All rights reserved.

> >   

> >   cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE
/D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_d1a3b.dir\Debug\" /Fd"cmTC_d1a3b.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

> >   CheckIncludeFile.c

> >   

> > C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot
open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d1a3b.vcxproj]

> > Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d1a3b.vcxproj" (default
targets) -- FAILED.

> > 

> > Build FAILED.

> > 

> > "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d1a3b.vcxproj" (default target) (1) ->

> > (ClCompile target) -> 

> >   C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot
open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d1a3b.vcxproj]

> > 

> >     0 Warning(s)

> >     1 Error(s)

> > 

> > Time Elapsed 00:00:01.13

> > 
> > 
> > ```

Oh, I see, fixing. Yay for CI testing multiple configurations.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review192473
-----------------------------------------------------------


On Nov. 30, 2017, 6:34 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 6:34 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, and Joseph Wu.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
>     sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> -------
> 
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message