mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63632: Migrated to event consumer interface.
Date Fri, 01 Dec 2017 17:25:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63632/#review192515
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp
Line 548 (original), 548 (patched)
<https://reviews.apache.org/r/63632/#comment270705>

    Can we remove the `virtual`s here similar to the libprocess patch?



src/master/master.cpp
Lines 1619 (patched)
<https://reviews.apache.org/r/63632/#comment270708>

    I think the `TODO` is sufficient as breadcrumb
    for us to know that we need to change code here.
    
    No need to make an extra copy of `MessageEvent`,
    here and below.


- Michael Park


On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63632/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Migrated to event consumer interface.
> 
> 
> Diffs
> -----
> 
>   src/common/recordio.hpp 378363492e04c141671fbed0467bf558b61e5dae 
>   src/master/master.hpp 0c1253aa1a88d113d42ce362d6992ad84217728c 
>   src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
>   src/tests/fetcher_cache_tests.cpp e2ecb102e2e7b4c4b3b2b736fdc453feeb15816e 
> 
> 
> Diff: https://reviews.apache.org/r/63632/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message