mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63630: Added support for callable once functors.
Date Fri, 01 Dec 2017 17:03:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63630/#review192510
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/lambda.hpp
Lines 357 (patched)
<https://reviews.apache.org/r/63630/#comment270696>

    Let's use `cpp17::invoke` here.



3rdparty/stout/include/stout/lambda.hpp
Lines 375 (patched)
<https://reviews.apache.org/r/63630/#comment270697>

    Let's elaborate on this comment a little bit around
    the heap allocation involved here due to
    the type-erasure and mention that `std::function`
    also has this overhead-ish.



3rdparty/stout/include/stout/lambda.hpp
Lines 393 (patched)
<https://reviews.apache.org/r/63630/#comment270693>

    Let's decay this earlier.



3rdparty/stout/include/stout/lambda.hpp
Lines 404 (patched)
<https://reviews.apache.org/r/63630/#comment270695>

    Can we make this a `unique_ptr` such that we can default some of the operations?



3rdparty/stout/include/stout/lambda.hpp
Lines 420-425 (patched)
<https://reviews.apache.org/r/63630/#comment270694>

    We recently started to stick to this pattern:
    ```
    tmeplate <typename F,
              typename std::enable_if<..., int>::type = 0>
    ```


- Michael Park


On Nov. 22, 2017, 6:10 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63630/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 6:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `CallableOnce` class is similar to `std::function`, but allows it to be
> called only once. Together with `partial` this provides foundation for
> copy-less `defer`, `dispatch` and `Future`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017 
> 
> 
> Diff: https://reviews.apache.org/r/63630/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message