mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 64247: Fixed a flaky test case in reservation tests.
Date Fri, 01 Dec 2017 14:46:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64247/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.


Bugs: MESOS-8289
    https://issues.apache.org/jira/browse/MESOS-8289


Repository: mesos


Description
-------

ReservationTest.MasterFailover could fail when parameterized with
the 'RESOURCE_PROVIDER' capability. After the simulated master failover,
the re-registered framework could receive an offer before the
re-registered sends a 'UPDATE_SLAVE' message. On receiving this message,
the master would rescind the offer and send out a new one. The test
expected a single offer to be send. It has been changed to accept the
first offer and ignore subsequent ones.

Also, the test case has been updated to run with paused clocks.


Diffs
-----

  src/tests/reservation_tests.cpp f29e9bbb3d3b4dbaf21cd04f5efcf0df7cc34459 


Diff: https://reviews.apache.org/r/64247/diff/1/


Testing
-------

src/mesos-tests

`src/mesos-tests --gtest_filter=ResourceProviderCapability/ReservationTest.MasterFailover/1
--gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the
background (on a 4 core machine)


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message