mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64226: Added a `ns::supported` convenience API.
Date Fri, 01 Dec 2017 11:25:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review192472
-----------------------------------------------------------



FAIL: Mesos libprocess-tests failed to build

Reviews applied: `['64226']`

Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226

Relevant logs:

- [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument':
conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]


"C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1)
->
(ClCompile target) -> 
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039:
'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861:
'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039:
'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861:
'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039:
'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861:
'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp)
[C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]

    96 Warning(s)
    6 Error(s)

Time Elapsed 00:04:26.85
```

- [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-CMakeOutput.log):

```
  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\".

InitializeBuildStatus:

  Creating "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_e0d77.dir\Debug\" /Fd"cmTC_e0d77.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_e0d77.dir\Debug\" /Fd"cmTC_e0d77.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e0d77.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.lib"
/MACHINE:X64  /machine:x64 cmTC_e0d77.dir\Debug\src.obj

  cmTC_e0d77.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e0d77.exe

  cmTC_e0d77.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\unsuccessfulbuild".

  Touching "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\cmTC_e0d77.lastbuildstate".

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_e0d77.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.82


Source file was:
int main() { return 0; }
```

- [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_7d048.dir\Debug\".

  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_7d048.dir\Debug\cmTC_7d048.tlog\".

InitializeBuildStatus:

  Creating "cmTC_7d048.dir\Debug\cmTC_7d048.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_7d048.dir\Debug\" /Fd"cmTC_7d048.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_7d048.dir\Debug\" /Fd"cmTC_7d048.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj]

Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.14



```

- Mesos Reviewbot Windows


On Nov. 30, 2017, 10:03 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 10:03 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-8284
>     https://issues.apache.org/jira/browse/MESOS-8284
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91 
>   src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 
>   src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b

>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e

>   src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d 
> 
> 
> Diff: https://reviews.apache.org/r/64226/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message