mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64065: Allowed resubscription of resource providers.
Date Fri, 01 Dec 2017 11:03:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64065/#review192464
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Jan! Will fix minor style nits while committing.


src/tests/mesos.hpp
Lines 2794 (patched)
<https://reviews.apache.org/r/64065/#comment270615>

    nit: Let's put these on their own lines.



src/tests/mesos.hpp
Line 2962 (original), 2968 (patched)
<https://reviews.apache.org/r/64065/#comment270616>

    Let's add an assertion here that `info.has_id()`.



src/tests/slave_tests.cpp
Lines 8987-8988 (original), 8994-8995 (patched)
<https://reviews.apache.org/r/64065/#comment270617>

    nit: Fits on a single line.



src/tests/slave_tests.cpp
Lines 8999-9000 (original), 9006-9007 (patched)
<https://reviews.apache.org/r/64065/#comment270618>

    nit: Fits on a single line.


- Benjamin Bannier


On Dec. 1, 2017, 9:45 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64065/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 9:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
> 
> 
> Bugs: MESOS-8269
>     https://issues.apache.org/jira/browse/MESOS-8269
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A resource provider can resubscribe by including the resource provider
> ID it got assigned as part of its 'ResourceProviderInfo' in a
> 'SUBSCRIBE' call. A resubscription is necessary if either the resource
> provider or the resource provider manager (i.e. an agent) failed over.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00 
>   src/tests/mesos.hpp 99542c599e7d0f5027e9358081822d91b526590e 
>   src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45

>   src/tests/slave_tests.cpp 1344e0a5376137b5b933edc9ea4a83be58542654 
> 
> 
> Diff: https://reviews.apache.org/r/64065/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message