mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63021: Added `getService()` function to launch CSI plugins.
Date Fri, 01 Dec 2017 01:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63021/
-----------------------------------------------------------

(Updated Dec. 1, 2017, 1:36 a.m.)


Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-8032
    https://issues.apache.org/jira/browse/MESOS-8032


Repository: mesos


Description
-------

The `getService()` method first checks if there is already a container
daemon for the specified plugin component, and creates a new one if not.
The post-start hook for the container daemon will call `connect()` to
wait for the endpoint socket file to appear and connect to it, then
set up the corresponding promise of CSI client. The post-stop hook will
remove the socket file and create a new promise for the next call to the
post-start hook to set it up.


Diffs (updated)
-----

  include/mesos/type_utils.hpp a348c7df083324602d25f40069ad49e29f7918a5 
  src/common/type_utils.cpp 3657d55ab2a052b5c659022e3fc264e748429d54 
  src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78 


Diff: https://reviews.apache.org/r/63021/diff/14/

Changes: https://reviews.apache.org/r/63021/diff/13-14/


Testing
-------


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message