mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 64195: Updated the tests to use MULTI_ROLE frameworks by default.
Date Fri, 01 Dec 2017 01:16:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64195/#review192421
-----------------------------------------------------------


Ship it!





src/tests/persistent_volume_tests.cpp
Line 150 (original), 152 (patched)
<https://reviews.apache.org/r/64195/#comment270565>

    This is to get a stable result from the `join` below, right?



src/tests/slave_tests.cpp
Line 860 (original), 860 (patched)
<https://reviews.apache.org/r/64195/#comment270562>

    Huh... so these used to be an empty string?


- Michael Park


On Nov. 29, 2017, 5:45 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64195/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:45 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-8237
>     https://issues.apache.org/jira/browse/MESOS-8237
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that we strip the `Resource.allocation_info` for non-MULTI_ROLE
> schedulers, it's simpler to default the tests to use the MULTI_ROLE
> capability, since we've already updated the majority of the tests
> to be aware of `Resource.allocation_info`.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 0136344c160ea6aeacc57e61382640689a77ee1a 
>   src/examples/disk_full_framework.cpp 28f71c35b32b46c7bf2cce9fe971266f7bd73c8a 
>   src/examples/dynamic_reservation_framework.cpp 5ee3867228a70c8fa0b4b5092fb44cb556a670e0

>   src/examples/long_lived_framework.cpp e6742159108f9eae4f2548bb84d6495309737d9c 
>   src/examples/no_executor_framework.cpp fd920f58f5ccb903127e9c6b112be30f04baa069 
>   src/examples/persistent_volume_framework.cpp 674d58a9e6fa34733f765d2925cedafeaab1eecd

>   src/examples/test_framework.cpp c6a293ed5f88bf4d73f23d97cbf9ffdd8b941f1a 
>   src/examples/test_http_framework.cpp 373035837f51e818629b1588d2ab8803c656f527 
>   src/tests/api_tests.cpp 66cb059c96ff9ecda594e13de9e5dc3909feeee3 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 421a72f1694a1a5c5e1bf4c525361dbd670c68af

>   src/tests/containerizer/docker_containerizer_tests.cpp 7a42bb93508abf9020d0bcc5b3daa2f6834be2e3

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 655f9f81f4bc55a85d7c5e27609a016254793380

>   src/tests/default_executor_tests.cpp 04d9e1b9d4682c3bb5355253e3a8e5b06d78e98f 
>   src/tests/disk_quota_tests.cpp fc297995c42821aa4b0a7719a6a19c3bbf65db47 
>   src/tests/fault_tolerance_tests.cpp 33a2220b4b4f019799db7b2482ce73b3454fa58e 
>   src/tests/hook_tests.cpp 2e58d1133343a96b67d0816a54ff8eb874522ba3 
>   src/tests/master_allocator_tests.cpp 3400d70bb0ba564eac43c4639eee0efd4d8059e6 
>   src/tests/master_authorization_tests.cpp eff97f155e7472a0cd5994408ed73474392593ad 
>   src/tests/master_quota_tests.cpp 058f6d24da50cbf3c28b091afa88f634a8102b62 
>   src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719 
>   src/tests/master_validation_tests.cpp 0e1c8b490ebe10bc50b8b6b530fa85128b967584 
>   src/tests/mesos.hpp f02c7c6962c9d0bee57712d8aad9997582c7404b 
>   src/tests/oversubscription_tests.cpp 2f403d3c9d2df7d5425b335781e8b62153854ef3 
>   src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 
>   src/tests/persistent_volume_endpoints_tests.cpp 883192d2badf8af87c95bc9a5fc3e711cd240193

>   src/tests/persistent_volume_tests.cpp b11d26e45c184cf3f0623629b898f67dc95c4fa0 
>   src/tests/reservation_endpoints_tests.cpp a96cc714fd40421a7db9a4c0debf71546daf5d4c

>   src/tests/reservation_tests.cpp fa375cd45e4c68551801521176632a56acd6d0ea 
>   src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45

>   src/tests/role_tests.cpp 084555ae70b80330cdc8729cd62f8baddf291a01 
>   src/tests/scheduler_http_api_tests.cpp 80e52fb22dbba4a0703f1b192205acaff89f883b 
>   src/tests/scheduler_tests.cpp 45fc9c0cfccdb22c2e3e8d5de30c04575814a0e9 
>   src/tests/slave_authorization_tests.cpp 11fd0d4e35523eca23a9603ecef0c9d0b65dde38 
>   src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 
>   src/tests/slave_tests.cpp a2274b691cf94b003c4bc15450d176a9c73517d5 
>   src/tests/upgrade_tests.cpp 7f434dbba858f636719eec24e92b306b76430c4c 
> 
> 
> Diff: https://reviews.apache.org/r/64195/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the tests, including with root.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message