From reviews-return-69386-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Nov 26 07:38:18 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 205D217CB5 for ; Sun, 26 Nov 2017 07:38:18 +0000 (UTC) Received: (qmail 50495 invoked by uid 500); 26 Nov 2017 07:38:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 50451 invoked by uid 500); 26 Nov 2017 07:38:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50440 invoked by uid 99); 26 Nov 2017 07:38:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Nov 2017 07:38:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C97DE180164; Sun, 26 Nov 2017 07:38:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gadPou6Lf6Fj; Sun, 26 Nov 2017 07:38:14 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7626A5FB91; Sun, 26 Nov 2017 07:38:14 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A6045E00CD; Sun, 26 Nov 2017 07:38:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7B5C4C402CF; Sun, 26 Nov 2017 07:38:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0972109152348069964==" MIME-Version: 1.0 Subject: Re: Review Request 63385: Added utility functions for CSI Plugin info and volume attributes. From: Chun-Hung Hsiao To: Jie Yu Cc: Chun-Hung Hsiao , Joseph Wu , mesos Date: Sun, 26 Nov 2017 07:38:11 -0000 Message-ID: <20171126073811.14710.49714@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63385/ X-Sender: Chun-Hung Hsiao References: <20171124234925.65411.30240@reviews-vm2.apache.org> In-Reply-To: <20171124234925.65411.30240@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/csi/utils.hpp X-ReviewBoard-Diff-For: src/csi/utils.cpp Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============0972109152348069964== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 24, 2017, 11:49 p.m., Jie Yu wrote: > > src/csi/utils.hpp > > Lines 36-43 (patched) > > > > > > Can you explain to me why you need the equality check for GetPluginInfoResponse? For checking if the controller plugin component and the node plugin component are consistent. > On Nov. 24, 2017, 11:49 p.m., Jie Yu wrote: > > src/csi/utils.hpp > > Lines 99 (patched) > > > > > > We don't do typedef, especially in header. > > > > Also, I feel this is a general protobuf util helper. We should put it under src/common/protobuf_utils.hpp|cpp > > > > ``` > > convertMapsToLabels(...) > > convertLabelsToMaps(...) > > ``` I originally put the functions here because it's used for converting a proto3 string-to-string map field to our proto2 `Labels`. But there should be no difference for `google::protobuf::Map` to handle proto2 and proto3 maps, and thus it should be safe to use these functions to handle both proto2 and proto3 maps. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/#review191845 ----------------------------------------------------------- On Nov. 22, 2017, 5:21 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63385/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 5:21 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added utility functions for CSI Plugin info and volume attributes. > > > Diffs > ----- > > src/csi/utils.hpp PRE-CREATION > src/csi/utils.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63385/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > > --===============0972109152348069964==--