From reviews-return-69366-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Nov 24 18:48:45 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 377541063A for ; Fri, 24 Nov 2017 18:48:45 +0000 (UTC) Received: (qmail 86954 invoked by uid 500); 24 Nov 2017 18:48:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86925 invoked by uid 500); 24 Nov 2017 18:48:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86914 invoked by uid 99); 24 Nov 2017 18:48:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2017 18:48:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0F2FA1A013B; Fri, 24 Nov 2017 18:48:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wVlVKS5s5_dF; Fri, 24 Nov 2017 18:48:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BF28F5F19B; Fri, 24 Nov 2017 18:48:41 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 087C4E00E5; Fri, 24 Nov 2017 18:48:41 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 01D39C40172; Fri, 24 Nov 2017 18:48:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7108145230336000578==" MIME-Version: 1.0 Subject: Re: Review Request 63377: Added filesystem layout for CSI plugins. From: Chun-Hung Hsiao To: Jie Yu , Joseph Wu , Jan Schlicht Cc: Mesos Reviewbot , Chun-Hung Hsiao , mesos Date: Fri, 24 Nov 2017 18:48:40 -0000 Message-ID: <20171124184840.65412.51080@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63377/ X-Sender: Chun-Hung Hsiao References: <20171121053641.62860.62781@reviews-vm2.apache.org> In-Reply-To: <20171121053641.62860.62781@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/csi/paths.cpp X-ReviewBoard-Diff-For: src/csi/paths.hpp Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============7108145230336000578== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/ ----------------------------------------------------------- (Updated Nov. 24, 2017, 6:48 p.m.) Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Changes ------- Addressed jieyu's comment. Bugs: MESOS-8141 https://issues.apache.org/jira/browse/MESOS-8141 Repository: mesos Description ------- A CSI plugin can now store the following persistent CSI data in `/csi///`: 1. Mount points of CSI volumes: `volumes/` 2. States of CSI volumes: `states//state` 3. Directory to place CSI endpoints: `/tmp/mesos-csi-XXXXXX`, which would be symlinked by `containers//endpoint`. Diffs (updated) ----- src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 src/csi/paths.hpp PRE-CREATION src/csi/paths.cpp PRE-CREATION src/slave/paths.hpp 66dfa4544772d78ccc9229dc861da60c79913f24 src/slave/paths.cpp b03ffeeed83cb73228cca27769262fb08df38fb5 Diff: https://reviews.apache.org/r/63377/diff/4/ Changes: https://reviews.apache.org/r/63377/diff/3-4/ Testing ------- make Thanks, Chun-Hung Hsiao --===============7108145230336000578==--