From reviews-return-69245-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Nov 21 22:28:14 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BEA2017469 for ; Tue, 21 Nov 2017 22:28:14 +0000 (UTC) Received: (qmail 85522 invoked by uid 500); 21 Nov 2017 22:28:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 85487 invoked by uid 500); 21 Nov 2017 22:28:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 85475 invoked by uid 99); 21 Nov 2017 22:28:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 22:28:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 90ABF18063E; Tue, 21 Nov 2017 22:28:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eVVlvApnPdpt; Tue, 21 Nov 2017 22:28:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34F1E5FBEA; Tue, 21 Nov 2017 22:28:12 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CD489E0E4A; Tue, 21 Nov 2017 22:28:11 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C669DC40449; Tue, 21 Nov 2017 22:28:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0162730819564498761==" MIME-Version: 1.0 Subject: Re: Review Request 63823: Initialized and subscribed storage local resource provider. From: Chun-Hung Hsiao To: Jie Yu , Joseph Wu , Jan Schlicht Cc: Chun-Hung Hsiao , mesos Date: Tue, 21 Nov 2017 22:28:11 -0000 Message-ID: <20171121222811.49374.85586@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63823/ X-Sender: Chun-Hung Hsiao References: <20171115023759.16898.63315@reviews-vm2.apache.org> In-Reply-To: <20171115023759.16898.63315@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============0162730819564498761== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63823/ ----------------------------------------------------------- (Updated Nov. 21, 2017, 10:28 p.m.) Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Changes ------- Rebased on r63904. Bugs: MESOS-8032 https://issues.apache.org/jira/browse/MESOS-8032 Repository: mesos Description ------- This patch validates `ResourceProviderInfo` for storage local resource providers upon creation. During initialization, the storage local resource provider first tries to recover its ID of the last session through reading the actual path linked by `/meta/resource_providers///latest`, then subscribe to the agent's resource provider manager. This patch is split from https://reviews.apache.org/r/63021/. Diffs (updated) ----- src/resource_provider/manager.cpp 6dfc42900a1e4249f37cec585f7fe50f5aa94e43 src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f Diff: https://reviews.apache.org/r/63823/diff/2/ Changes: https://reviews.apache.org/r/63823/diff/1-2/ Testing (updated) ------- make Thanks, Chun-Hung Hsiao --===============0162730819564498761==--