From reviews-return-68201-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Nov 4 01:13:40 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0210010E91 for ; Sat, 4 Nov 2017 01:13:40 +0000 (UTC) Received: (qmail 83422 invoked by uid 500); 4 Nov 2017 01:13:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83386 invoked by uid 500); 4 Nov 2017 01:13:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83375 invoked by uid 99); 4 Nov 2017 01:13:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Nov 2017 01:13:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B6BEB1808BE; Sat, 4 Nov 2017 01:13:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id regi6TDd4V3y; Sat, 4 Nov 2017 01:13:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A7A155F3E2; Sat, 4 Nov 2017 01:13:37 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54D6DE00B3; Sat, 4 Nov 2017 01:13:37 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 205ADC40307; Sat, 4 Nov 2017 01:13:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5947607519695182914==" MIME-Version: 1.0 Subject: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root. From: Chun-Hung Hsiao To: Jie Yu , Joseph Wu , Gilbert Song , Jan Schlicht Cc: Chun-Hung Hsiao , mesos Date: Sat, 04 Nov 2017 01:13:34 -0000 Message-ID: <20171104011334.24300.70001@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63498/ X-Sender: Chun-Hung Hsiao Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============5947607519695182914== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63498/ ----------------------------------------------------------- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs: MESOS-7550 https://issues.apache.org/jira/browse/MESOS-7550 Repository: mesos Description ------- If the `root` field is set to a relative path, it would mean that the path is relative to the agent work directory. This provides the ability for an isolator to construct the mount point of a CSI volume without knowing the resource provider info. Diffs ----- include/mesos/mesos.proto 68a5538904b601a91a40db68cebde96f74a2f160 include/mesos/v1/mesos.proto c46cec78db63dc3714e357a954a4e7bf080485fd src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 Diff: https://reviews.apache.org/r/63498/diff/1/ Testing ------- make check Thanks, Chun-Hung Hsiao --===============5947607519695182914==--