| Michael Park |
Re: Review Request 63569: CMake: Compile the 3rdparty dependencies with the same compiler. |
Mon, 06 Nov, 01:20 |
| Michael Park |
Re: Review Request 63569: CMake: Compile the 3rdparty dependencies with the same compiler. |
Mon, 06 Nov, 02:01 |
| Michael Park |
Re: Review Request 63569: CMake: Compile the 3rdparty dependencies with the same compiler. |
Mon, 06 Nov, 02:04 |
| Michael Park |
Re: Review Request 62734: Added --markdown and --target-people to post-reviews.py. |
Mon, 06 Nov, 02:22 |
| Michael Park |
Re: Review Request 63232: Converted SlaveInfo resources from the registry during master recovery. |
Mon, 06 Nov, 03:24 |
| Michael Park |
Re: Review Request 63232: Converted SlaveInfo resources from the registry during master recovery. |
Mon, 06 Nov, 03:25 |
| Michael Park |
Re: Review Request 63565: MesosTidy: Added some `google-*` checks to the default set of checks. |
Mon, 06 Nov, 07:31 |
| Michael Park |
Re: Review Request 63565: MesosTidy: Added some `google-*` checks to the default set of checks. |
Mon, 06 Nov, 18:17 |
| Michael Park |
Re: Review Request 62734: Added Markdown, bug, and reviewers support to `post-reviews.py`. |
Mon, 06 Nov, 18:33 |
| Michael Park |
Review Request 63591: Flattened unnecessary `Optional<Shared<T>>` to simply `Shared<T>`. |
Mon, 06 Nov, 18:54 |
| Michael Park |
Re: Review Request 63567: MesosTidy: Removed redundant `get()` on smart pointers in libprocess. |
Mon, 06 Nov, 18:55 |
| Michael Park |
Re: Review Request 63568: MesosTidy: removed redundant `get()` on smart pointers in mesos. |
Mon, 06 Nov, 18:58 |
| Michael Park |
Re: Review Request 63568: MesosTidy: removed redundant `get()` on smart pointers in mesos. |
Mon, 06 Nov, 18:59 |
| Michael Park |
Re: Review Request 63590: Enabled CredentialsTests on Windows. |
Mon, 06 Nov, 19:16 |
| Michael Park |
Review Request 63649: Introduced `.clang-tidy` configuration file. |
Tue, 07 Nov, 22:02 |
| Michael Park |
Re: Review Request 63649: Introduced `.clang-tidy` configuration file. |
Tue, 07 Nov, 22:14 |
| Michael Park |
Re: Review Request 63611: Refactored scheduler test driver to avoid using uninitialized object. |
Mon, 13 Nov, 19:26 |
| Michael Park |
Re: Review Request 63613: Refactored executor test driver to avoid using uninitialized object. |
Mon, 13 Nov, 19:29 |
| Michael Park |
Re: Review Request 63614: Removed unnecessary check in v1 scheduler library. |
Mon, 13 Nov, 19:29 |
| Michael Park |
Re: Review Request 63615: Passed scheduler as a shared pointer into the callback. |
Mon, 13 Nov, 19:29 |
| Michael Park |
Re: Review Request 60620: Modifed os::write to write binary files on Windows. |
Wed, 15 Nov, 23:34 |
| Michael Park |
Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest). |
Thu, 16 Nov, 17:50 |
| Michael Park |
Re: Review Request 60622: Added new stout functions for path and URI conversions. |
Thu, 16 Nov, 18:08 |
| Michael Park |
Re: Review Request 60623: Converted "file://" URI handling to use new uri function. |
Thu, 16 Nov, 18:08 |
| Michael Park |
Re: Review Request 60624: Enabled HDFS compilation and associated tests. |
Thu, 16 Nov, 18:08 |
| Michael Park |
Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform. |
Thu, 16 Nov, 23:08 |
| Michael Park |
Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows. |
Thu, 16 Nov, 23:10 |
| Michael Park |
Review Request 63930: MesosTidy: Turned on [misc-use-after-move]. |
Sat, 18 Nov, 00:03 |
| Michael Park |
Review Request 63931: MesosTidy [misc-use-after-move]: Fixed `HashMapTest` test. |
Sat, 18 Nov, 00:03 |
| Michael Park |
Review Request 63932: MesosTidy [misc-use-after-move]: Added `NOLINT` to false-positives. |
Sat, 18 Nov, 00:03 |
| Michael Park |
Review Request 63933: MesosTidy [misc-use-after-move]: Arguments moved into chained calls. |
Sat, 18 Nov, 00:03 |
| Michael Park |
Review Request 63976: Modified `downgradeResources` to use protobuf reflection. |
Tue, 21 Nov, 06:07 |
| Michael Park |
Review Request 63977: Used the protobuf-reflection-based `downgradeResources` utility. |
Tue, 21 Nov, 06:07 |
| Michael Park |
Re: Review Request 63628: Implemented index_sequence and related functionality. |
Wed, 22 Nov, 10:41 |
| Michael Park |
Re: Review Request 64009: Added new UpdateSlave registry operation. |
Wed, 29 Nov, 16:30 |
| Michael Park |
Re: Review Request 63628: Implemented index_sequence and related functionality. |
Thu, 30 Nov, 17:57 |
| Qian Zhang |
Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`. |
Wed, 01 Nov, 11:45 |
| Qian Zhang |
Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`. |
Wed, 01 Nov, 11:45 |
| Qian Zhang |
Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`. |
Wed, 01 Nov, 11:46 |
| Qian Zhang |
Re: Review Request 63331: Added documentation for the `network/ports` isolator. |
Wed, 01 Nov, 12:47 |
| Qian Zhang |
Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update. |
Thu, 02 Nov, 03:16 |
| Qian Zhang |
Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`. |
Thu, 02 Nov, 03:17 |
| Qian Zhang |
Review Request 63499: Fixed the unit test that broke Windows build. |
Thu, 02 Nov, 05:27 |
| Qian Zhang |
Re: Review Request 63499: Fixed the unit test that broke Windows build. |
Thu, 02 Nov, 07:58 |
| Qian Zhang |
Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update. |
Thu, 02 Nov, 08:12 |
| Qian Zhang |
Re: Review Request 63499: Fixed the unit test that broke Windows build. |
Thu, 02 Nov, 08:21 |
| Qian Zhang |
Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`. |
Thu, 02 Nov, 09:27 |
| Qian Zhang |
Re: Review Request 63499: Fixed the unit test that broke Windows build. |
Thu, 02 Nov, 23:51 |
| Qian Zhang |
Re: Review Request 63499: Fixed the unit test that broke Windows build. |
Thu, 02 Nov, 23:54 |
| Qian Zhang |
Review Request 63577: Fixed a task status update race in default executor tests. |
Mon, 06 Nov, 13:31 |
| Qian Zhang |
Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`. |
Mon, 06 Nov, 13:32 |
| Qian Zhang |
Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors. |
Tue, 07 Nov, 00:37 |
| Qian Zhang |
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks. |
Tue, 07 Nov, 14:22 |
| Qian Zhang |
Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`. |
Thu, 09 Nov, 02:03 |
| Qian Zhang |
Re: Review Request 63577: Fixed a task status update race in default executor tests. |
Fri, 10 Nov, 13:00 |
| Qian Zhang |
Re: Review Request 63577: Fixed a task status update race in default executor tests. |
Fri, 10 Nov, 13:02 |
| Qian Zhang |
Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class. |
Tue, 14 Nov, 13:27 |
| Qian Zhang |
Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Tue, 14 Nov, 13:30 |
| Qian Zhang |
Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check. |
Tue, 14 Nov, 13:31 |
| Qian Zhang |
Re: Review Request 63577: Fixed a task status update race in default executor tests. |
Wed, 15 Nov, 06:21 |
| Qian Zhang |
Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class. |
Thu, 16 Nov, 07:20 |
| Qian Zhang |
Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class. |
Thu, 16 Nov, 07:20 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Thu, 16 Nov, 07:21 |
| Qian Zhang |
Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check. |
Thu, 16 Nov, 07:22 |
| Qian Zhang |
Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check. |
Thu, 16 Nov, 07:23 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Fri, 17 Nov, 12:53 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Fri, 17 Nov, 12:57 |
| Qian Zhang |
Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class. |
Fri, 17 Nov, 12:58 |
| Qian Zhang |
Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Fri, 17 Nov, 13:25 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Fri, 17 Nov, 13:35 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Sun, 19 Nov, 13:38 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Sun, 19 Nov, 13:41 |
| Qian Zhang |
Re: Review Request 63577: Fixed a task status update race in default executor tests. |
Mon, 20 Nov, 02:42 |
| Qian Zhang |
Review Request 63943: Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`. |
Mon, 20 Nov, 02:44 |
| Qian Zhang |
Re: Review Request 63577: Fixed a task status update race in default executor tests. |
Mon, 20 Nov, 02:46 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Wed, 22 Nov, 15:14 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Wed, 22 Nov, 15:14 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Fri, 24 Nov, 02:14 |
| Qian Zhang |
Review Request 64062: Added 6 nested container tests for `docker/volume` isolator. |
Fri, 24 Nov, 14:23 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Sun, 26 Nov, 00:55 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Mon, 27 Nov, 02:20 |
| Qian Zhang |
Re: Review Request 52006: Supported docker/volume isolator to be nested aware. |
Mon, 27 Nov, 07:12 |
| Qian Zhang |
Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6. |
Mon, 27 Nov, 14:43 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Tue, 28 Nov, 11:12 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Tue, 28 Nov, 11:13 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Tue, 28 Nov, 11:17 |
| Qian Zhang |
Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container. |
Tue, 28 Nov, 12:46 |
| Qian Zhang |
Re: Review Request 64171: Fixed the multi taskgroup shared pid ns test due to slowness. |
Wed, 29 Nov, 23:35 |
| Till Toenshoff |
Review Request 63463: Added support for credential secret to test-http-framework. |
Wed, 01 Nov, 14:39 |
| Till Toenshoff |
Re: Review Request 63494: Removed unused declaration. |
Mon, 06 Nov, 10:57 |
| Till Toenshoff |
Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted. |
Thu, 09 Nov, 10:03 |
| Tomasz Janiszewski |
Re: Review Request 63400: Fix bad links. |
Mon, 06 Nov, 14:23 |
| Tomasz Janiszewski |
Re: Review Request 63400: Fix bad links. |
Mon, 06 Nov, 14:25 |
| Tomasz Janiszewski |
Re: Review Request 63400: Fix bad links. |
Wed, 08 Nov, 17:06 |
| Vinod Kone |
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks. |
Thu, 02 Nov, 18:55 |
| Vinod Kone |
Re: Review Request 63526: Fixed TASK_UNKNOWN status ambiguity. |
Fri, 03 Nov, 21:59 |
| Vinod Kone |
Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG. |
Fri, 03 Nov, 22:01 |
| Vinod Kone |
Re: Review Request 63437: Slave heartbeat add message sender distinguish. |
Fri, 03 Nov, 22:26 |
| Vinod Kone |
Re: Review Request 63400: Fix bad links. |
Fri, 03 Nov, 22:33 |
| Vinod Kone |
Re: Review Request 63400: Fix bad links. |
Fri, 03 Nov, 22:34 |