mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.
Date Thu, 30 Nov 2017 23:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63276/
-----------------------------------------------------------

(Updated Nov. 30, 2017, 3:34 p.m.)


Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, Joseph
Wu, Li Li, and Michael Park.


Changes
-------

Rebased, fixed style, used correct resources protobuf, fixed to support unspecified resources
(required for nested containers and things like the `ContainerDaemon` where a unit test specifies
`None()` for resources).


Bugs: MESOS-5462 and MESOS-6690
    https://issues.apache.org/jira/browse/MESOS-5462
    https://issues.apache.org/jira/browse/MESOS-6690


Repository: mesos


Description (updated)
-------

Instead of deriving from the POSIX isolators, we now have two real
Windows isolators that can be used together or separately. The `Cpu`
isolator enables a hard-cap CPU limit, and the `Mem` isolator enables a
hard-cap memory limit on the job object for the container.

These classes are separate derivations of `MesosIsolatorProcess`,
because introducing a `WindowsIsolatorProcess` base class would be
abstraction for the sole purpose of code deduplication.

Note that these isolators support nesting, and so must support empty
`cpu` or `mem` resources. When these are not provided, the corresponding
code to set the limits is simply not called.


Diffs (updated)
-----

  src/CMakeLists.txt 76ef6cac925e36a31e4f6c347271955411284056 
  src/Makefile.am 4a3b728dc2cbfaf4b10068562778a87a6b331238 
  src/slave/containerizer/mesos/containerizer.cpp 7f3b86d87cf82429c2627d4a32eb0d5adbcc3f29

  src/slave/containerizer/mesos/isolators/windows.hpp b0621a5fc411b8812722f7fcf6580ed64dac5382

  src/slave/containerizer/mesos/isolators/windows/cpu.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/windows/cpu.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/windows/mem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/windows/mem.cpp PRE-CREATION 
  src/slave/flags.cpp 7998d9bb66995ad0d1285fcb1042321afdf917a9 


Diff: https://reviews.apache.org/r/63276/diff/4/

Changes: https://reviews.apache.org/r/63276/diff/3-4/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message