mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64146: Added offer operation update acknowledgement to the agent.
Date Thu, 30 Nov 2017 23:33:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64146/#review192391
-----------------------------------------------------------




src/slave/slave.cpp
Lines 3850 (patched)
<https://reviews.apache.org/r/64146/#comment270503>

    Ditto. I don't think we can remove the operation based on `latest_status`.
    
    Also, I would comment here saying that: If the ack is dropped (RP disconnected), during
RP re-registration, an UPDATE_STATE will be triggered to tell the agent about the removed
operation, and agent will add it back.



src/slave/slave.cpp
Lines 3851 (patched)
<https://reviews.apache.org/r/64146/#comment270507>

    Currently, for agent default resources, we call `removeOfferOperation` right after the
operation is processed (given that we don't have status update manager or checkpointing for
operations), and send best effort status update to the master.
    
    I am wondering if we need ack at all for agent default resources operations. That mean,
we should probably remove the offer operation for agent default resources in `offerOperationStatusUpdate`.
    
    If there is a fail over, and the update is lost, the agent will reconcile with the master
during re-registration and master will notice that and call removeOfferOperation there (in
updateSlave handler).


- Jie Yu


On Nov. 29, 2017, 5:56 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64146/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
>     https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent's offerOperationUpdateAcknowlegement handler is
> updated to pass acknowledgements to the resource provider
> manager.
> 
> The agent's resource provider message handler is also
> updated to avoid removing offer operations, since this
> should actually be done upon acknowledgement of the update.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb 
> 
> 
> Diff: https://reviews.apache.org/r/64146/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message